Skip to content

feat: addon install require to specify the version#457

Merged
ldming merged 3 commits intomainfrom
support/addon-install-require-version
Oct 10, 2024
Merged

feat: addon install require to specify the version#457
ldming merged 3 commits intomainfrom
support/addon-install-require-version

Conversation

@ldming
Copy link
Copy Markdown
Collaborator

@ldming ldming commented Oct 10, 2024 •
edited
Loading 

bin/kbcli addon install mysql
error: required flag(s) "version" not set

bin/kbcli addon install mysql --version=""
error: please specify the version, run 'kbcli addon search mysql' to get the available versions

@github-actions github-actions Bot added the size/S Denotes a PR that changes 10-29 lines. label Oct 10, 2024
@github-actions github-actions Bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Oct 10, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.48%. Comparing base (6a48d8f) to head (34e56c3).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   43.49%   43.48%   -0.01%     
==========================================
  Files         175      175              
  Lines       24885    24884       -1     
==========================================
- Hits        10823    10821       -2     
- Misses      12799    12800       +1     
  Partials     1263     1263
Flag Coverage Δ
unittests 43.48% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldming
Copy link
Copy Markdown
Collaborator Author

ldming commented Oct 10, 2024

/approve

@ldming ldming merged commit 65f8876 into main Oct 10, 2024
@ldming ldming deleted the support/addon-install-require-version branch October 10, 2024 09:00
@github-actions github-actions Bot added this to the Release 1.0 milestone Oct 10, 2024
@ldming
Copy link
Copy Markdown
Collaborator Author

ldming commented Oct 10, 2024

/cherry-pick release-0.9

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 10, 2024

🤖 says: Error cherry-picking.

Auto-merging docs/user_docs/cli/kbcli_addon_install.md
CONFLICT (content): Merge conflict in docs/user_docs/cli/kbcli_addon_install.md
Auto-merging pkg/cmd/addon/install.go
CONFLICT (content): Merge conflict in pkg/cmd/addon/install.go
error: could not apply 65f8876... feat: addon install require to specify the version (#457)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 10, 2024

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kbcli/actions/runs/11270813326

ldming added a commit that referenced this pull request Oct 10, 2024
@ldming
feat: addon install require to specify the version (#457)
3db8f66 
(cherry picked from commit 65f8876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangyelei wangyelei wangyelei approved these changes

@shanshanying shanshanying shanshanying approved these changes

@apecloud-bot apecloud-bot apecloud-bot approved these changes

@nayutah nayutah Awaiting requested review from nayutah nayutah is a code owner

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om

@leon-inf leon-inf Awaiting requested review from leon-inf

@1aal 1aal Awaiting requested review from 1aal 1aal is a code owner

Assignees

No one assigned

Labels

size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Milestone

Release 1.0

Development

Successfully merging this pull request may close these issues.

[Improvement] kbcli install addon must specify VERSION options

5 participants

@ldming @codecov-commenter @wangyelei @shanshanying @apecloud-bot